Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace invalid variable name in Boxscore modules #484

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

roclark
Copy link
Owner

@roclark roclark commented Sep 28, 2020

Newer versions of pycodestyle flag inadequate variable names, such as single letters, which should be replaced with more descriptive names.

Fixes #485

Signed-Off-By: Robert Clark robdclark@outlook.com

Newer versions of pycodestyle flag inadequate variable names, such as
single letters, which should be replaced with more descriptive names.

Signed-Off-By: Robert Clark <robdclark@outlook.com>
@roclark roclark added the enhancement New feature or request label Sep 28, 2020
@roclark roclark added this to the Release 0.6.0 milestone Sep 28, 2020
@roclark roclark self-assigned this Sep 28, 2020
@roclark roclark added quality of life Any updates that improve the overall quality of the code and removed enhancement New feature or request labels Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #484 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files          55       55           
  Lines       13023    13023           
=======================================
  Hits        13020    13020           
  Misses          3        3           
Impacted Files Coverage Δ
sportsreference/mlb/boxscore.py 100.00% <100.00%> (ø)
sportsreference/nba/boxscore.py 100.00% <100.00%> (ø)
sportsreference/nfl/boxscore.py 99.81% <100.00%> (ø)
sportsreference/nhl/boxscore.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e692654...a7a1c31. Read the comment docs.

@roclark roclark merged commit 369cf44 into master Sep 28, 2020
@roclark roclark deleted the fix-pycodestyle-errors branch September 28, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality of life Any updates that improve the overall quality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update inadequate variable names
1 participant